search

szmarczak / http2-wrapper

Use HTTP/2 the same way like HTTP/1
MIT License
239 stars 18 forks source link

Breaking builds #63

Closed bkniffler closed 3 years ago

bkniffler commented 3 years ago

Latest version is breaking builds. I've installed got, not using http2-wrapper directly, and nodejs15 is required.

tabrez96 commented 3 years ago

Facing the same issue.

error http2-wrapper@1.0.0: The engine "node" is incompatible with this module. Expected version ">=15.10.0". Got "12.21.0"
cesine commented 3 years ago

Same for us, @szmarczak i will prep a PR https://github.com/szmarczak/http2-wrapper/pull/64

update: the pr isnt viable. i wonder if you could make a patch 1.0.1 that has the old code and use 2.x for dropping the node support? 

10:27:51  error http2-wrapper@1.0.0: The engine "node" is incompatible with this module. Expected version ">=15.10.0". Got "12.13.1"

Tracing in our yarn.lock 

got@11.8.1:
  version "11.8.1" 
  dependencies:
    "@sindresorhus/is" "^4.0.0"
    "@szmarczak/http-timer" "^4.0.5"
    "@types/cacheable-request" "^6.0.1"
    "@types/responselike" "^1.0.0"
    cacheable-lookup "^5.0.3"
    cacheable-request "^7.0.1"
    decompress-response "^6.0.0"
    http2-wrapper "^1.0.0-beta.5.2"
    lowercase-keys "^2.0.0"
    p-cancelable "^2.0.0"
    responselike "^2.0.0"
pataar commented 3 years ago

Same here

domtaylor commented 3 years ago

Same here! Hope you can fix asap

gustavkj commented 3 years ago

I have the same issue. But a solution seems to be in the making over on got: https://github.com/sindresorhus/got/pull/1640

szmarczak commented 3 years ago

Fixed. I ~thought~ didn't think that the ^ would up the beta version into a stable one.

szmarczak commented 3 years ago

😅

szmarczak commented 3 years ago

Ok so I released 1.0.3 which is 100% the same beta version. The new version is released as 2.0.0. Sorry for the trouble.