search

szpak / gradle-pitest-plugin

Gradle plugin for PIT Mutation Testing
http://gradle-pitest-plugin.solidsoft.info/
221 stars 58 forks source link

Remove Gradle 4.0 workaround from PitestTask.exec #217

Closed pkubowicz closed 4 years ago

pkubowicz commented 4 years ago

The comment says:

//Workaround for compatibility with Gradle <4.0 due to setArgs(List) and setJvmArgs(List) added in Gradle 4.0

but the plugin requires Gradle 5.6 at minimum.

szpak commented 4 years ago

You are right. I will remove it along the way with the other code modifications.

pkubowicz commented 4 years ago

Are you sure this is correct? This commit removed just the comment.

szpak commented 4 years ago

I also expected something bigger, but looking at the old commit I switched from calling the setter directly and probably with settings some protected field directly (due to some compatibility issues with lower Gradle 4.x - based on the comments - it was Sep 5, 2017). However, that Groovy syntax currently seems to call setters under the hood (field could be removed in the meantime), so it is also fine (for Groovy code).