szpak / gradle-pitest-plugin

Gradle plugin for PIT Mutation Testing
http://gradle-pitest-plugin.solidsoft.info/
214 stars 58 forks source link

[#333] Fix Gradle configuration cache issues for 8.1 and up #345

Closed davidburstrom closed 1 year ago

davidburstrom commented 1 year ago

The fix has a test but it's not hooked into the build because of cascading version incompatibility issues, which the pitest-gradle-plugin project needs to deal with.

szpak commented 1 year ago

Thanks @davidburstrom. Could you make that PR against devel? I have recently added tests execution also with Gradle 8.2 and they seem to pass (at least the very basic one with PIT)?

However, if after the rebase with devel you have the tests still failing due to the Spock/Groovy reasons, I will try to fix it.

davidburstrom commented 1 year ago

I realized it was better to change the target than opening a new PR to said target.

davidburstrom commented 1 year ago

However, if after the rebase with devel you have the tests still failing due to the Spock/Groovy reasons, I will try to fix it.

They still fail, sorry.

szpak commented 1 year ago

They still fail, sorry.

Thanks for trying.

However, as I see, it passes with JDK 11 and 15, but fails with OpenJ9. Even stranger, on the step to download it :thinking: . Maybe it is some temporary issue on Travis. I will have a look at it.

szpak commented 1 year ago

It succeeded after two retries, but... I forgot that test is ignored :-D.

davidburstrom commented 1 year ago

Thanks for fixing the test! Would you like me to ship the PR?

szpak commented 1 year ago

Thanks for fixing the test! Would you like me to ship the PR?

No, I was rather waiting for your - potential - feedback (e.g. that something could be improved).

Thanks for the PR!

davidburstrom commented 1 year ago

Cool, looking forward to the release :)

szpak commented 1 year ago

Cool, looking forward to the release :)

Me too :-). I would like to make some other changes before the release though :-/

Vampire commented 1 year ago

Any idea when we can expect the release? :-) I think this plugin is the last bit of a build I'm currently working on that is not CC compatible.

szpak commented 1 year ago

Any idea when we can expect the release? :-) I think this plugin is the last bit of a build I'm currently working on that is not CC compatible.

I understand. I will try to release something "soon".

Vampire commented 1 year ago

Great, thanks. :-) Well, actually it is the next to last thing. Release plugin is much worse, but I worked around that. :-D

szpak commented 1 year ago

Releasing GPP is acutally as easy as git commit -m "Trigger release" --allow-empty && git push, but providing the features I would really like in the next version is much worse :-). As a last resort, I will just cut the scope :-/.

Vampire commented 1 year ago

I think you misunderstood. :-D I previously said GPP is the last thing. Bit then remembered it is the next to last thing and the gradle-release plugin is much worse.

szpak commented 1 year ago

I think you misunderstood. :-D

Reading your answer, probably. "Release[ing a] plugin is much worse" could be taken as a grammar mistake. Anyway, I'm glad, you worked around the problems with the gradle-release plugin.

Btw, is it better than GNPP or it is just "more actively developed"?

Vampire commented 1 year ago

It's definitely less active developed. But the comparison is not appropriate. Both plugins have nothing to do with each other and I use both. The release plugin increases version, runs tests, creates release tags, triggers the publishing, and so on.

szpak commented 1 year ago

It's definitely less active developed. But the comparison is not appropriate. Both plugins have nothing to do with each other and I use both. The release plugin increases version, runs tests, creates release tags, triggers the publishing, and so on.

Cool, I will have to take a look at it as a potential replacement of my hand-made release solution.