szquadri / droidsshd

Automatically exported from code.google.com/p/droidsshd
0 stars 0 forks source link

Allow Blank Password #10

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Enter Preferences -> Service and Authentication -> Password
2. Blank out password.
3. Save.
4. Start the server.
5. Attempt to connect.

What is the expected output? What do you see instead?

I would expect this to disable password login, and allow login via pubkey ONLY. 
 Instead, the server does not start correctly.

Reading the code, it looks like the process that generates the command line may 
not quote string parameters safely (and may not escape quotes within parameter 
values).  It looks like dropbear WOULD support no-password if '' is passed in 
as a password parameter, based on the Dropbear Android patch 
(http://jblomer.web.cern.ch/jblomer/dropbear0.52-android.patch).

What version of the product are you using? On what operating system?

DroidSSHd Version 2010-12-05 (sha1=7ed35d783085a09c04441c34706c2f703e03d795), 
running on HTC Dream (G1), Cyanogen 6.1.0-DS (Android 2.2.1), Kernel 
2.6.35.9-cyanogenmod shade@toxygene #2, Build FRG83.

Please provide any additional information below.

Original issue reported on code.google.com by Warr1...@gmail.com on 1 Feb 2011 at 4:12