szwacz / fs-jetpack

Better file system API for Node.js
MIT License
777 stars 41 forks source link

Drop use of rimraf #110

Closed binyamin closed 2 years ago

binyamin commented 2 years ago

Fixes #103

I replaced rimraf with the native Node.js fs.rm() function. This requires Node.js 14, which is the lowest LTS version anyway. I updated the CI environments to match.

codecov[bot] commented 2 years ago

Codecov Report

Merging #110 (b8f15dc) into master (8b6c4cb) will decrease coverage by 0.35%. The diff coverage is 100.00%.

:exclamation: Current head b8f15dc differs from pull request most recent head 05eea65. Consider uploading reports for the commit 05eea65 to get more accurate results

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   95.70%   95.34%   -0.36%     
==========================================
  Files          25       25              
  Lines        1419     1417       -2     
  Branches      277      277              
==========================================
- Hits         1358     1351       -7     
- Misses         61       66       +5     
Impacted Files Coverage Δ
lib/remove.js 100.00% <100.00%> (ø)
lib/utils/tree_walker.js 82.17% <0.00%> (-3.88%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b6c4cb...05eea65. Read the comment docs.

szwacz commented 2 years ago

Thank you. Will check it soon :)

szwacz commented 2 years ago

Released in v5.0.0 (finally :D )