search

szwacz / fs-jetpack

Better file system API for Node.js
MIT License
777 stars 41 forks source link

Add realpath library function #121

Open joshblum opened 10 months ago

szwacz commented 10 months ago

Thanks for the PR. I have problem finding windows dev machine to tinker with failed tests ;) Will come back to it.

joshblum commented 10 months ago

Took a guess at what the windows problem could be but also don't have a windows dev machine setup. Could you try running CI again on the change? Thanks!

codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 97.45763% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.94%. Comparing base (79f53db) to head (f211f50).

Files Patch % Lines
lib/realpath.js 90.47% 2 Missing :warning:
spec/realpath.spec.ts 98.86% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #121 +/- ## ========================================== + Coverage 96.92% 96.94% +0.01% ========================================== Files 52 54 +2 Lines 4624 4740 +116 Branches 25 25 ========================================== + Hits 4482 4595 +113 - Misses 123 126 +3 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.