search

szwacz / fs-jetpack

Better file system API for Node.js
MIT License
777 stars 41 forks source link

Use rimraf (fixes #80) #81

Closed papb closed 5 years ago

papb commented 5 years ago

Fixes #80. Replaces current remove() code with rimraf.

Note: I've decided to use { disableGlob: true } as an option to rimraf because the previous code for remove didn't do anything with globs - and also, I don't want to make a breaking change with this PR, only a fix for intermittent errors.

codecov-io commented 5 years ago

Codecov Report

Merging #81 into master will increase coverage by 0.93%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
+ Coverage   96.37%   97.31%   +0.93%     
==========================================
  Files          24       24              
  Lines        1269     1229      -40     
  Branches      247      231      -16     
==========================================
- Hits         1223     1196      -27     
+ Misses         46       33      -13
Impacted Files Coverage Δ
lib/remove.js 100% <100%> (+24.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1139659...f5da24b. Read the comment docs.

szwacz commented 5 years ago

Thanks! Released as v2.2.2.