search

szweier / SZMentions

Library to help handle mentions
MIT License
11 stars 1 forks source link

fix issue with incorrect highlighting and character replacement on ch… #3

Closed szweier closed 8 years ago

szweier commented 8 years ago

…inese keyboard

Ferrick90 commented 8 years ago

@szweier PRs Looks good. But defaultAttributes and mentionAttributes got some issue.

12659608_10205773470206515_1259942065_n

I think defaultAttributes and mentionsAttributes should apply same font type and font size.

szweier commented 8 years ago

If you set a font for mention attributes you should also be sure to set a font for default attributes so it changes back. Was the example shown running my example or are these changes you made.

szweier commented 8 years ago

If this is happening with changes you've made can you submit a PR with the setup. If not I'll check tomorrow to see why the font wouldn't be changing back. Currently I'm not sure why this would happen outside of not specifying a default font. My intention was to allow for the default and mentions attributes to be highly customizable. I could potentially add a check that would issue an alert or some sort of warning if you provided an attribute for either default or mention attributes that do not exist on both. That warning should allow for anyone using the library to know that what you've shown above could happen.

szweier commented 8 years ago

I'll work on the other issue mentioned here in a new PR