szymanowiczs / splatter-image

Official implementation of `Splatter Image: Ultra-Fast Single-View 3D Reconstruction' CVPR 2024
https://szymanowiczs.github.io/splatter-image
BSD 3-Clause "New" or "Revised" License
795 stars 54 forks source link

The question when calculating focal_pixel #13

Closed Xin-97 closed 7 months ago

Xin-97 commented 7 months ago

Hi @szymanowiczs,

Thanks for your great work. I am a new one in this field. I found a formula for focal_length to focal_pixel, F(mm) = F(pixels) * SensorWidth(mm) / ImageWidth (pixel). When you calculate focal_pixel here https://github.com/szymanowiczs/splatter-image/blob/a2cbd6df67b2e34d10c8808dc1e8fe0daf4c02c7/scene/dataset_readers.py#L114 Why you set sensorwidth to 2? Thanks!

StellarCheng commented 7 months ago

Thanks for your work! And I also wonder how to find some parameters in the configs too.

截屏2024-01-15 21 05 27
szymanowiczs commented 7 months ago

Hi @Xin-97 this is because CO3D cameras are in NDC coordinates: see bottom of the page here. https://pytorch3d.org/docs/cameras.