szymanowiczs / splatter-image

Official implementation of `Splatter Image: Ultra-Fast Single-View 3D Reconstruction' CVPR 2024
https://szymanowiczs.github.io/splatter-image
BSD 3-Clause "New" or "Revised" License
795 stars 54 forks source link

A bug in srn.py #25

Closed River-Zhang closed 4 months ago

River-Zhang commented 6 months ago

Hi, it an excellent work. But I came into something wrong. I find that the code in srn.py line 22 is self.base_path = os.path.join(SHAPENET_DATASET_ROOT, "srn_{}/{}_{}".format(cfg.data.category, cfg.data.category, cfg.data.category, dataset_name))

However this causes a wrong path, shouldn't it be self.base_path = os.path.join(SHAPENET_DATASET_ROOT, "srn_{}/{}_{}".format(cfg.data.category, cfg.data.category, dataset_name)) The number of parameter is three not four.

yuedajiong commented 5 months ago

https://github.com/szymanowiczs/splatter-image/issues/10#issuecomment-1994176872

szymanowiczs commented 4 months ago

Fixed now.