szymex / xbmc-finnish-tv

XBMC Video Plugins for playing Finnish television content containers.
GNU General Public License v3.0
31 stars 38 forks source link

Include html5lib for ruutu-plugin. #77

Closed kontza closed 9 years ago

kontza commented 9 years ago

I've tried the Ruutu-plugin on different computers at home (and at work). Most of them are Linux boxes and a single MacBook. On some of the machines, ruutu-plugin's scraper does not detect program titles, and whatnot.

Then I read the docs on BS4 stating that some Pythons' html-parser does not work reliably. Therefore I added html5lib into the plugin, and Hey presto! Those 'broken' boxes started to display program information properly.

Html5lib is slow, but it's a pure Python implementation, therefore, I think, the most suitable to be used in a Kodi-plugin.

The real commit containing the stuff that matters is e8b701d.

szymex commented 9 years ago

Thanks a lot!

szymex commented 9 years ago

Actually, changes you made broke ruutu, I'm getting this error: Error Contents: Couldn't find a tree builder with the features you requested: html5lib. Do you need to install a parser library?