search

szymonmaszke / vimpyter

Edit your Jupyter notebooks in Vim/Neovim
MIT License
333 stars 17 forks source link

On-demand loading of plugins by vim-plug #8

Closed maamo888 closed 6 years ago

maamo888 commented 6 years ago

I am using a plugin manager called vim-plug.

If filetype is ipynb only, it can not be a way such as to load the vimpyter.

https://github.com/junegunn/vim-plug#on-demand-loading-of-plugins

.vimrc

Plug 'vyzyv/vimpyter', { 'for': ['ipynb'] }
szymonmaszke commented 6 years ago

Will look into lazy loading of plugins, thanks for pointing that out.

It may not work since .ipynb filetype is defined by this plugin, it doesn't exist on it's own in vim/nvim.

maamo888 commented 6 years ago

Thank you for reply.

I am waiting for correction and change.

Additional report.

Plug 'jmcantrell/vim-virtualenv', { 'for': ['python', 'djangohtml', 'htmljinja', 'ipynb'] }
Plug 'davidhalter/jedi-vim', { 'for': ['python', 'ipynb'], 'do': 'git submodule update --init' }
Plug 'Vimjas/vim-python-pep8-indent', { 'for': ['python', 'ipynb'] }
Plug 'heavenshell/vim-pydocstring', { 'for': ['python', 'ipynb'] }
szymonmaszke commented 6 years ago

This plugin is already loaded only on .ipynb files. It is really small and rather fast (check your vim startup time and this plugin's contribution to it).

I don't think it's worth the effort honestly, but if you wish you can implement it and I'll happily merge your PR.

What about additional report? Is jedi-vim working for you with .ipynb files? I can't make it work that way.

Closing, if you want to submit PR or have any additional info do not hesitate to open it.