t-affeldt / climate_api

An expansive weather engine for Minetest
https://forum.minetest.net/viewtopic.php?f=9&t=24569
Other
9 stars 4 forks source link

Deprecated calls, luacheck, and optimize some parts #4

Closed mazes-80 closed 1 year ago

mazes-80 commented 2 years ago

removed some things guided by luacheck, 1 deprecated call. for performances: reduced the number of calls to minetest.get_connected_players() to 1 at each step.

mazes-80 commented 2 years ago

Seems to me the mod is now using bit less resources. profiler mod returned me an average of about 20% before, now it seems about 10% with same settings for the mod itself. though profiler result does not seem steady, my feelings when playing in my home server are better.

t-affeldt commented 1 year ago

Sorry for the late notice. I verified it and it's running as expected. Thank you! :)

mazes-80 commented 1 year ago

Le Tue, 21 Feb 2023 18:11:42 -0800, Till Affeldt @.***> a écrit :

Sorry for the late notice. I verified it and it's running as expected. Thank you! :)

Very nice to see this PR merged. It reduced CPU usage quite a bit locally.