completely desaturates the world

[Lemente]

When using this mod and with shaders activated (MTG weather off), the world is almost completely desaturated. more info :

• MTG game
• Minetest 5.7 on windows 10
• only the Regional Weather Bundle installed

doing "/set_weather regional_weather:ambient off" solves the issue, but I assume it also removes some of the mod features.

[APercy]

To fix it, change the function map_range at file "regional_weather/ca_weathers/ambient.lua", line 15, to this: `

-- maps range of 0 to 1 to any other range
local function map_range(val, low, high)
    local cal_val = math.min(math.max(val, 0), 1)
    local range = high - low
    return low + (cal_val * range)
end

`

[t-affeldt]

Hello! Sorry for the late reply as I don't have time for modding and as such, cannot offer much support.

This bug is caused by a misconfigured feature. I implemented it when shaders were still under development and then didn't correct for changes to them when they were officially released.

It is supposed to simulate diffused lighting conditions under overcast weather. Unfortunately, the values are set way too extreme, so that it appears either way too desaturated or way too saturated. I hadn't felt a need to make them configurable, so there is no easy way to fix it without changing something in the code. You can disable tone maps in your Minetest settings to disable the feature but it might affect other visual aspects.

For those willing to change two lines of code, you can tweak the values in ambient.lua to your liking (lines 30 and 37). More info on my forum post. I am willing to accept push requests if they come with screenshots.

[t-affeldt]

This is now fixed in the latest version. :)