t-affeldt / regional_weather

A diverse weather pack for Minetest using Climate API
https://forum.minetest.net/viewtopic.php?f=9&t=24569
Other
4 stars 2 forks source link

Request a tool for cleaning up puddles #9

Open mowgli opened 1 year ago

mowgli commented 1 year ago

I like the weather effects. But there is one thing that disturbs me. There is no good way to cleanup the water puddles. Usually this is not needed but for example, it is not possible to use the rake on soil when there is a puddle on top of it.

There are more possible solutions:

animaux commented 10 months ago

I’m also looking for an easy way to remove all puddles after deinstalling the mod. Also when turning off puddles in the settings, the world is polluted with unknown blocks.

animaux commented 9 months ago

No dice?

t-affeldt commented 4 months ago

Firstly, sorry for the very late reply. I currently don't have any for modding, so unfortunately this mod is mostly abandoned for the time being.

I’m also looking for an easy way to remove all puddles after deinstalling the mod. Also when turning off puddles in the settings, the world is polluted with unknown blocks.

The code that is supposed to clean them is indeed broken. Since I don't have the time for a fix, I suggest using a cleanup mod instead to remove the puddles. This one can be found on the ContentDB but I have not tested it and don't offer support for it: https://content.minetest.net/packages/AntumDeluge/cleaner/

If any other modder is willing to take this on, it can be found in the /abms/puddle.lua file. Currently, it only deactivates a single puddle node when it needs to loop over all of them.

t-affeldt commented 4 months ago

Make the puddles like water so one can modify the underlying block

Water is a bit special in the way it is coded into the engine and cannot easily be recreated without also adapting all other properties of liquids. It is, however, possible to reduce the size of the hitbox so that you can still access the block underneath.

Add a sweeping tool to clean the puddle Make the rake working on the puddle.

The good news: These are already on my roadmap :) The bad news: I don't actively work on any of my mods at the moment because of a lack of time. :( So unfortunately, I cannot implement any of those things right now.

For the time being, you could deactivate the puddles if they annoy you. Note my previous comment, though, on how to remove pre-existing ones.

animaux commented 4 months ago

The code that is supposed to clean them is indeed broken. Since I don't have the time for a fix, I suggest using a cleanup mod instead to remove the puddles. This one can be found on the ContentDB but I have not tested it and don't offer support for it: https://content.minetest.net/packages/AntumDeluge/cleaner/

Many thanks for the hint, I can totally understand your lack of time. The problem with all the tools I tried so far is that the node names are numbered, e. g. regional_weather:puddle_33. Maybe there is a way to use a wildcard, but I haven’t been able to find it so far.

animaux commented 4 months ago

Update. Was able to use cleaner successfully with the following cleaner.json:

{
    "entities" : 
    {
        "remove" : []
    },
    "items" : 
    {
        "replace" : {}
    },
    "nodes" : 
    {
        "remove" : 
        [
            "regional_weather:puddle_8_flipped",
            "regional_weather:puddle_9_flipped",
            "regional_weather:puddle_10_flipped",
            "regional_weather:puddle_11_flipped",
            "regional_weather:puddle_12_flipped",
            "regional_weather:puddle_13_flipped",
            "regional_weather:puddle_14_flipped",
            "regional_weather:puddle_15_flipped",
            "regional_weather:puddle_16_flipped",
            "regional_weather:puddle_17_flipped",
            "regional_weather:puddle_18_flipped",
            "regional_weather:puddle_19_flipped",
            "regional_weather:puddle_20_flipped",
            "regional_weather:puddle_21_flipped",
            "regional_weather:puddle_22_flipped",
            "regional_weather:puddle_23_flipped",
            "regional_weather:puddle_24_flipped",
            "regional_weather:puddle_25_flipped",
            "regional_weather:puddle_26_flipped",
            "regional_weather:puddle_27_flipped",
            "regional_weather:puddle_28_flipped",
            "regional_weather:puddle_29_flipped",
            "regional_weather:puddle_30_flipped",
            "regional_weather:puddle_31_flipped",
            "regional_weather:puddle_32_flipped",
            "regional_weather:puddle_33_flipped",
            "regional_weather:puddle_34_flipped",
            "regional_weather:puddle_35_flipped",
            "regional_weather:puddle_36_flipped",
            "regional_weather:puddle_37_flipped",
            "regional_weather:puddle_38_flipped",
            "regional_weather:puddle_39_flipped",
            "regional_weather:puddle_40_flipped",
            "regional_weather:puddle_41_flipped",
            "regional_weather:puddle_42_flipped",
            "regional_weather:puddle_43_flipped",
            "regional_weather:puddle_44_flipped",
            "regional_weather:puddle_45_flipped",
            "regional_weather:puddle_46_flipped",
            "regional_weather:puddle_47_flipped",
            "regional_weather:puddle_48_flipped",
            "regional_weather:puddle_49_flipped",
            "regional_weather:puddle_50_flipped",
            "regional_weather:puddle_51_flipped",
            "regional_weather:puddle_52_flipped",
            "regional_weather:puddle_53_flipped",
            "regional_weather:puddle_54_flipped",
            "regional_weather:puddle_55_flipped",
            "regional_weather:puddle_56_flipped",
            "regional_weather:puddle_57_flipped",
            "regional_weather:puddle_58_flipped",
            "regional_weather:puddle_59_flipped",
            "regional_weather:puddle_60_flipped",
            "regional_weather:puddle_61_flipped",
            "regional_weather:puddle_62_flipped",
            "regional_weather:puddle_63_flipped",
            "regional_weather:puddle_64_flipped",
            "regional_weather:puddle_65_flipped",
            "regional_weather:puddle_66_flipped",
            "regional_weather:puddle_67_flipped",
            "regional_weather:puddle_68_flipped",
            "regional_weather:puddle_69_flipped",
            "regional_weather:puddle_70_flipped",
            "regional_weather:puddle_71_flipped",
            "regional_weather:puddle_72_flipped",
            "regional_weather:puddle_1",
            "regional_weather:puddle_2",
            "regional_weather:puddle_3",
            "regional_weather:puddle_4",
            "regional_weather:puddle_5",
            "regional_weather:puddle_6",
            "regional_weather:puddle_7",
            "regional_weather:puddle_8",
            "regional_weather:puddle_9",
            "regional_weather:puddle_10",
            "regional_weather:puddle_11",
            "regional_weather:puddle_12",
            "regional_weather:puddle_13",
            "regional_weather:puddle_14",
            "regional_weather:puddle_15",
            "regional_weather:puddle_16",
            "regional_weather:puddle_17",
            "regional_weather:puddle_18",
            "regional_weather:puddle_19",
            "regional_weather:puddle_20",
            "regional_weather:puddle_21",
            "regional_weather:puddle_22",
            "regional_weather:puddle_23",
            "regional_weather:puddle_24",
            "regional_weather:puddle_25",
            "regional_weather:puddle_26",
            "regional_weather:puddle_27",
            "regional_weather:puddle_28",
            "regional_weather:puddle_29",
            "regional_weather:puddle_30",
            "regional_weather:puddle_31",
            "regional_weather:puddle_32",
            "regional_weather:puddle_33",
            "regional_weather:puddle_34",
            "regional_weather:puddle_35",
            "regional_weather:puddle_36",
            "regional_weather:puddle_37",
            "regional_weather:puddle_38",
            "regional_weather:puddle_39",
            "regional_weather:puddle_40",
            "regional_weather:puddle_41",
            "regional_weather:puddle_42",
            "regional_weather:puddle_43",
            "regional_weather:puddle_44",
            "regional_weather:puddle_45",
            "regional_weather:puddle_46",
            "regional_weather:puddle_47",
            "regional_weather:puddle_48",
            "regional_weather:puddle_49",
            "regional_weather:puddle_50",
            "regional_weather:puddle_51",
            "regional_weather:puddle_52",
            "regional_weather:puddle_53",
            "regional_weather:puddle_54",
            "regional_weather:puddle_55",
            "regional_weather:puddle_56",
            "regional_weather:puddle_57",
            "regional_weather:puddle_58",
            "regional_weather:puddle_59",
            "regional_weather:puddle_60",
            "regional_weather:puddle_61",
            "regional_weather:puddle_62",
            "regional_weather:puddle_63",
            "regional_weather:puddle_64",
            "regional_weather:puddle_65",
            "regional_weather:puddle_66",
            "regional_weather:puddle_67",
            "regional_weather:puddle_68",
            "regional_weather:puddle_69",
            "regional_weather:puddle_70",
            "regional_weather:puddle_71",
            "regional_weather:puddle_72",
            "regional_weather:puddle_73",
            "regional_weather:puddle_1_flipped",
            "regional_weather:puddle_2_flipped",
            "regional_weather:puddle_3_flipped",
            "regional_weather:puddle_4_flipped",
            "regional_weather:puddle_5_flipped",
            "regional_weather:puddle_6_flipped",
            "regional_weather:puddle_7_flipped",
            "regional_weather:puddle_73_flipped"
        ],
        "replace" : {}
    },
    "ores" : 
    {
        "remove" : []
    }
}

Not sure how many different numbered types of puddles there are, maybe only 30. But this worked anyhow :)