search

t-anc / GSP-Qbittorent-Gluetun-sync-port-mod

Docker mod for Linuxserver's Qbittorrent image to sync gluetun's forwarded port. Can also work with any qBittorrent image as a standalone container.
GNU General Public License v3.0
76 stars 4 forks source link

silence output of qbt_login, fix #4 #5

Closed ibrokemypie closed 2 months ago

ibrokemypie commented 2 months ago

I believe this is a fix for https://github.com/t-anc/GSP-Qbittorent-Gluetun-sync-port-mod/issues/4, the "Ok." was the output coming out of the qbt_login call to curl, resulting in the "Ok.200" seen. Unfortunately been struggling to test this due to issues getting the image to pull my forked mod image through the vpn, but I am pretty sure this is the fix.

t-anc commented 2 months ago

Oh, yeah it makes sense. I'll test this when I have some time, probably this week-end. Thank you for the contribution.

ibrokemypie commented 2 months ago

Just got the linuxserver.io mod working to test the fix, works for me!

t-anc commented 2 months ago

I've looked at it this week-end, and instead of silencing the login, I've modified the check to test for the "Ok." string rather than the HTTP code. I think that it's cleaner.

Anyway thank you for the issue, the analysis and the PR :)