t-artistik / qtscriptgenerator

Automatically exported from code.google.com/p/qtscriptgenerator
0 stars 0 forks source link

Always include all the includes, since they are required anyways #39

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
QtScript Generator actually requires Webkit, Phonon and QtXmlPatterns
because of qtbindings/qtbindingsbase.pri. 

So the easy fix is to just always require it, since most distros have the
Qt defines that say Webkit and Phonon doesn't exist even though they do.
Thats what the patch does.

I had to use the lowercase phonon includes since KDE's phonon doesn't have
an equivalent to phonon/phonon.

Original issue reported on code.google.com by ian.mon...@gmail.com on 20 Mar 2009 at 2:06

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
To be clear, this patch simply works around misconfigured/broken qt installs 
(which
seems to be common in distros)?

In fairness, I recently had to fix qt in fedora so that it's (non-conflicting)
headers were installed, due to qt vs kde phonon, and header case issue you 
mentioned.

Original comment by rdieter@gmail.com on 21 Mar 2009 at 5:47

GoogleCodeExporter commented 8 years ago
what's this against? it doesn't seem to apply against 0.1.0

Original comment by XenoTerr...@gmail.com on 22 Mar 2009 at 12:25

GoogleCodeExporter commented 8 years ago
the following attachement is the the same patch but for 0.1.0 I still can't get
qtscriptgenerator 0.1.0 to build, but it appears to be for different reasons.

Original comment by XenoTerr...@gmail.com on 22 Mar 2009 at 1:51

Attachments:

GoogleCodeExporter commented 8 years ago
@rdieter maybe partially. Mostly its that the notion of using Qt macros to 
decide if
something is installed is broken. Just because it wasn't installed when Qt was 
built
is only tangentially related to whether its installed now. To check if 
something is
installed you need a full configure check (which qmake has limited capabilities
doing, though it probably could be done).

Since most everyone has webkit, phonon and qtxmlpatterns installed it might not 
be
worth doing a configure check.

Original comment by ian.mon...@gmail.com on 23 Mar 2009 at 1:37