Closed jsarha closed 5 years ago
I was expecting the common file and header to go away. Who's using it now?
I think you first need to remove the dependency to mhdp-common from mdhp. After that, restore the rockchip driver, including removing the common file.
I was expecting the common file and header to go away. Who's using it now?
Yes. I forgot about that. I should remove them in "drm/bridge: cdns-mhdp: Remove dependencies to cdns-mhdp-common".
I think you first need to remove the dependency to mhdp-common from mdhp. After that, restore the rockchip driver, including removing the common file.
I rather restore the rockchip first, because otherwise I need to keep mhdp-common linked to our bridge driver still after removing the dependency to it, because rockchip is selecting CDNS_MHDP and depend on the exported mhdp-common functions linked to it.
I propose removing the common files at the same time with removing the bridge driver dependencies to the common functions. Would that be ok?
There is a new request, closing this one.
drm/bridge: cdns-mhdp: Cleanup and async FW loading
On more (hopefully) final round. The only functional change is spin locking in mhdp_remove().
Changes since v6:
Changes since v5:
Changes since v4:
Changes since v3:
Changes since v2:
Changes since v1:
This series drops all dependencies to cdns-mhdp-common and Rockchip legacy code. On top of that it changes the firmware loading to happen asynchronously so that the DRM device can pull itself up even if the firmware is not yet available.
Jyri Sarha (7): drm/bridge: cdns-mhdp: Remove completely untested audio support drm/rockchip: Restore everything to what is there in v4.19.73 drm/bridge: cdns-mhdp: Remove dependencies to cdns-mhdp-common drm/bridge: cdns-mhdp: Drop useless container structs drm/bridge: cdns-mhdp: Handle probe failures correctly drm/bridge: cdns-mhdp: Call phy_exit() in mhdp_remove() drm/bridge: cdns-mhdp: Probe and add the bridge even without firmware
drivers/gpu/drm/bridge/Makefile | 2 +- drivers/gpu/drm/bridge/cdns-mhdp-j721e.h | 2 +- drivers/gpu/drm/bridge/cdns-mhdp.c | 846 +++++++++++++++----- drivers/gpu/drm/bridge/cdns-mhdp.h | 70 +- drivers/gpu/drm/rockchip/Kconfig | 4 +- drivers/gpu/drm/rockchip/Makefile | 2 +- drivers/gpu/drm/rockchip/cdn-dp-core.c | 234 +++--- drivers/gpu/drm/rockchip/cdn-dp-core.h | 42 +- drivers/gpu/drm/rockchip/cdn-dp-reg.c | 969 +++++++++++++++++++++++ drivers/gpu/drm/rockchip/cdn-dp-reg.h | 482 +++++++++++ 10 files changed, 2341 insertions(+), 312 deletions(-) create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.c create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.h