Cleanup and async fw load v7

[jsarha]

drm/bridge: cdns-mhdp: Cleanup and async FW loading

On more (hopefully) final round. The only functional change is spin locking in mhdp_remove().

Changes since v6:

• Remove left over #define DEBUG 1
• Fix some typos from "drm/bridge: cdns-mhdp: Probe and add the bridge even without firmware" comments and commit description
• Add spin lock to mhdp_remove() when checking hw_enabled
• Restore "Reviewed-by: Tomi Valkeinen tomi.valkeinen@ti.com" to "drm/bridge: cdns-mhdp: Remove dependencies to cdns-mhdp-common" since the patch is again identical to v3 version of it

Changes since v5:

• Add "drm/rockchip: Restore everything to what is there in v4.19.73"
• "drm/bridge: cdns-mhdp: Probe and add the bridge even without firmware"
  • Remove double linefeed that caused a checkpatch error
  • Use plain spinlock functions (not irqsave/restore ones)
  • Only send hotplug event in mhdp_fw_cb() if the bridge was attached NOTE: There is a potential race related to this patch still. It is in theory possible that the bridge is detached after we released the spinlock and before sending the hotplug event. In practice this does not happen since bridges are usually not detached at all and certainly not right after boot when the firmware is still loading. It is too late and my brain does not function properly any more so I do not try to come up with a solution to this now, but just add an XXX comment.

Changes since v4:

• "drm/bridge: cdns-mhdp: Remove dependencies to cdns-mhdp-common"
  • Restore linking of cdns-mhdp-common.o to CONFIG_DRM_CDNS_MHDP to avoid breaking ROCKCHIP_CDN_DP build. Also removes Tomi's reviewed-by and adds a note about cdns-mhdp-common.o linking to the commit message.

Changes since v3:

• Reviewed-by: Tomi Valkeinen tomi.valkeinen@ti.com to patches 1-5
• Fix sparse errors and address Tomi's review comment in "drm/bridge: cdns-mhdp: Probe and add the bridge even without firmware"

Changes since v2:

• Fix checkpatch issues
• Protect only hw_enabled and bridge_attached with mutex in "drm/bridge: cdns-mhdp: Probe and add the bridge even without firmware"
• Set uvevent parameter of request_firmware_nowait() to true in "drm/bridge: cdns-mhdp: Probe and add the bridge even without firmware" (This was actually done already to v2 series, but forgot it from the change log.)

Changes since v1:

• Split "drm/bridge: cdns-mhdp: Remove completely untested audio support" as a separate patch from "drm/bridge: cdns-mhdp: Remove dependencies..."
• Split "drm/bridge: cdns-mhdp: Call phy_exit() in mhdp_remove()" as a separate patch form "drm/bridge: cdns-mhdp: Probe and add the bridge"
• No changes to cdns_mhdp_get_modes() in "drm/bridge: cdns-mhdp: Probe and add the bridge even without firmware"

This series drops all dependencies to cdns-mhdp-common and Rockchip legacy code. On top of that it changes the firmware loading to happen asynchronously so that the DRM device can pull itself up even if the firmware is not yet available.

Jyri Sarha (7): drm/bridge: cdns-mhdp: Remove completely untested audio support drm/rockchip: Restore everything to what is there in v4.19.73 drm/bridge: cdns-mhdp: Remove dependencies to cdns-mhdp-common drm/bridge: cdns-mhdp: Drop useless container structs drm/bridge: cdns-mhdp: Handle probe failures correctly drm/bridge: cdns-mhdp: Call phy_exit() in mhdp_remove() drm/bridge: cdns-mhdp: Probe and add the bridge even without firmware

drivers/gpu/drm/bridge/Makefile | 2 +- drivers/gpu/drm/bridge/cdns-mhdp-j721e.h | 2 +- drivers/gpu/drm/bridge/cdns-mhdp.c | 846 +++++++++++++++----- drivers/gpu/drm/bridge/cdns-mhdp.h | 70 +- drivers/gpu/drm/rockchip/Kconfig | 4 +- drivers/gpu/drm/rockchip/Makefile | 2 +- drivers/gpu/drm/rockchip/cdn-dp-core.c | 234 +++--- drivers/gpu/drm/rockchip/cdn-dp-core.h | 42 +- drivers/gpu/drm/rockchip/cdn-dp-reg.c | 969 +++++++++++++++++++++++ drivers/gpu/drm/rockchip/cdn-dp-reg.h | 482 +++++++++++ 10 files changed, 2341 insertions(+), 312 deletions(-) create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.c create mode 100644 drivers/gpu/drm/rockchip/cdn-dp-reg.h

[tomba]

I was expecting the common file and header to go away. Who's using it now?

[tomba]

I think you first need to remove the dependency to mhdp-common from mdhp. After that, restore the rockchip driver, including removing the common file.

[jsarha]

I was expecting the common file and header to go away. Who's using it now?

Yes. I forgot about that. I should remove them in "drm/bridge: cdns-mhdp: Remove dependencies to cdns-mhdp-common".

[jsarha]

I think you first need to remove the dependency to mhdp-common from mdhp. After that, restore the rockchip driver, including removing the common file.

I rather restore the rockchip first, because otherwise I need to keep mhdp-common linked to our bridge driver still after removing the dependency to it, because rockchip is selecting CDNS_MHDP and depend on the exported mhdp-common functions linked to it.

I propose removing the common files at the same time with removing the bridge driver dependencies to the common functions. Would that be ok?

[jsarha]

There is a new request, closing this one.