search

t-crest / patmos

Patmos is a time-predictable VLIW processor, and the processor for the T-CREST project
http://patmos.compute.dtu.dk
BSD 2-Clause "Simplified" License
134 stars 72 forks source link

Bugfix EthMac without PTP #127

Closed epsilon-0311 closed 2 years ago

epsilon-0311 commented 2 years ago

Directions of slave ports inside EthMac without PTP were wronge: https://github.com/t-crest/patmos/blob/cbaa19065c8eaa432aa4679c7d255d3708068e56/hardware/src/main/scala/io/EthMac.scala#L225 

[error] firrtl.passes.CheckFlows$WrongFlow:  @[EthMac.scala 225:14]: [module EthMac]  Expression eth.S is used as a SinkFlow but can only be used as a SourceFlow.
[error] firrtl.passes.CheckFlows$WrongFlow:  @[EthMac.scala 225:14]: [module EthMac_1]  Expression eth.S is used as a SinkFlow but can only be used as a SourceFlow.
[error] firrtl.passes.PassException: 2 errors detected!
[error] firrtl.passes.PassExceptions: 
[error] firrtl.passes.CheckFlows$WrongFlow:  @[EthMac.scala 225:14]: [module EthMac]  Expression eth.S is used as a SinkFlow but can only be used as a SourceFlow.
[error] firrtl.passes.CheckFlows$WrongFlow:  @[EthMac.scala 225:14]: [module EthMac_1]  Expression eth.S is used as a SinkFlow but can only be used as a SourceFlow.
[error] firrtl.passes.PassException: 2 errors detected!
[error] Nonzero exit code: 1
[error] (Compile / runMain) Nonzero exit code: 1
[error] Total time: 4 s, completed May 11, 2022 8:43:12 AM

Additionally: EthMac2 seems to be an outdated version of EthMac -> deleted

schoeberl commented 2 years ago

I do not understand why this makes a difference, as <> should be bidirectional. However, I will merge.