search

t-crest / patmos

Patmos is a time-predictable VLIW processor, and the processor for the T-CREST project
http://patmos.compute.dtu.dk
BSD 2-Clause "Simplified" License
135 stars 72 forks source link

Commiting PTP library demo #35

Closed egk696 closed 6 years ago

egk696 commented 6 years ago

Includes progress for ArgoNoC (new board configuration .xml and top level patmos_de2_115-ptp.vhdl)

schoeberl commented 6 years ago

Also don't introduce a new .xml file if not needed. Same for Quartus projects.

egk696 commented 6 years ago

Yes my mistake for adding in the ArgoNoC.

egk696 commented 6 years ago

I think the .xml and Quartus project is a bit necessary since someone might be working with an existing configuration file and introduce problems unexpected behavior to their code. My configuration adds 2 components that are not found in any other configuration of the board. Same goes for the new quartus project.

schoeberl commented 6 years ago

What components are added to the Quartus project file? If it is just Chisel, there is no need for a new Quartus project file. About .xml: your additional devices are commented out, therefore no difference to the default .xml files that exists. After stating this fact, I would argue that we should have one DE2 configuration that contains everything (I started an altde2-all.xml), such as Ethernet, SD-card, LED 7-segment display,... whatever we have. We should consolidate to avoid having zillion configuration files, one for each new peripheral device. Maybe one minimal and one have it all.

egk696 commented 6 years ago

The Quartus project file just assigns the pins for the seven-segment display. I agree with having one XML per board. Should I commit with the altde2-all ? And place there my PTP options for EthMac ?

Let me know to fix my commit.

schoeberl commented 6 years ago

Yes, add the pins in (and use) altde2-all.

egk696 commented 6 years ago

Hi Martin,

I removed the Argo files and also based the PTP demo on altde2-all configuration. Let me know if something is missing, I think it is ready for merge.

schoeberl commented 6 years ago

I'll merge. Please in the future move your application code into an apps project.