search

t-crest / patmos

Patmos is a time-predictable VLIW processor, and the processor for the T-CREST project
http://patmos.compute.dtu.dk
BSD 2-Clause "Simplified" License
135 stars 72 forks source link

cmp: Support for cmp devices with pins; redundant devices not generated #43

Closed torurstrom closed 5 years ago

torurstrom commented 5 years ago

resolves #39

schoeberl commented 5 years ago

LGTM, but what are those changes (in all lines?) in EMAC? This is unrelated.

torurstrom commented 5 years ago

Ah, yeah just formatting fixes. Replaced tabs with spaces and \r\n with \n.

torurstrom commented 5 years ago

Also, I added support for 1-8 core emulator instead of 1,2 and 4, which is also unrelated. Tell me if I should remove any of the changes for this commit, although, I do want to push them to master regardless.

schoeberl commented 5 years ago

Bad boy, committing \r\n DOS style EOL into a repository ;-) This should be handled locally, right?

On 22 Jan, 2019, at 21:29, torurstrom notifications@github.com wrote:

Ah, yeah just formatting fixes. Replaced tabs with spaces and \r\n with \n.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/t-crest/patmos/pull/43#issuecomment-456675393, or mute the thread https://github.com/notifications/unsubscribe-auth/AAntmA3PNGhu0JeQVHxZXjtPrZVvYgbfks5vF_MxgaJpZM4aOC_V.

schoeberl commented 5 years ago

I see the fixes with the hard coded 4 core in the emulator. Thanks for elevating this issue a bit.

I think all looks good to me.

Martin

On 22 Jan, 2019, at 21:37, torurstrom notifications@github.com wrote:

Also, I added support for 1-8 core emulator instead of 1,2 and 4, which is also unrelated. Tell me if I should remove any of the changes for this commit, although, I do want to push them to master regardless.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/t-crest/patmos/pull/43#issuecomment-456676795, or mute the thread https://github.com/notifications/unsubscribe-auth/AAntmCpCtTae78QbG-NSpUXApD1DhDxyks5vF_UjgaJpZM4aOC_V.