search

t-houssian / fillpdf

A python library to make filling pdfs much easier
MIT License
134 stars 23 forks source link

Command line interface #14

Closed jtplaarj closed 2 years ago

jtplaarj commented 2 years ago

First of all, thanks for the library. Really helpful.

I think it may be really useful (at least it is for me) a command line interface.

I have done some simple wrappers for your library: cli_fillpdf

If you think is useful, you could add the code to the library, if not, I will keep it public and made if available through pip.

t-houssian commented 2 years ago

@jtplaarj Great idea and great work! I checked out your repo and think it looks really good! I would definitely add this into the library code. How would you like to add the code to the library? I am open to any ideas you have.

jtplaarj commented 2 years ago

I am very amateur in python and GitHub but I imagine that there are two ways:

I suppose that the "correct" GitHub way is the second option. Most likely the first is the simplest.

Any case, you should decide if the command names are OK or you prefer something else. I am quite bad at naming things 😅.

t-houssian commented 2 years ago

Do you think you could clone then PR? If you run into issues I could go the copy and paste rout too. I think the names are fitting for now.

jtplaarj commented 2 years ago

Done, I think ;)

15

t-houssian commented 2 years ago

@Thanks, I merged the pull request and documented your functions in the readme file. Let me know if anything is not documented right.

jtplaarj commented 2 years ago

i completely forgot the documentation!!! I must admit that you have done a much better job that I would have done. I have created a PR to fix missing -o option in extractfillpdf

16

t-houssian commented 2 years ago

@jtplaarj All good man! Merged it in, thanks for fixing that.