search

t-lutz / ParallelSTL

Implementation of n3554, a proposal to include parallelized versions of the STL algorithms into the C++ standard.
25 stars 6 forks source link

Removed broken test for for_each #23

Closed maribu closed 8 years ago

maribu commented 8 years ago

I believe the test Accumulate for for_each to be wrong: The result of the function for_each is applying will be ignored, so this function will not change the array. Also I don't believe that fixing this test would increase test coverage, as the test Doubler already does that, what the test Accumulate would do once fixed. So I simply removed it.

t-lutz commented 8 years ago

Thanks, this test was originally testing accumulation but I changed it when we changed the prototype in the proposal. I should have removed it instead of changing it.