search

t-mart / ItemVersion

ItemVersion adds information to your tooltip about when an item was added to World of Warcraft.
https://www.curseforge.com/wow/addons/itemversion
GNU General Public License v3.0
9 stars 8 forks source link

Create frFR.lua #71

Closed Brainc3ll closed 7 months ago

Brainc3ll commented 7 months ago

French translation

Type of changes

Checklist

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

Brainc3ll commented 7 months ago

Hello, this is my first time with github, if i made mistake, i'm sorry ;)

t-mart commented 7 months ago

Hello, this is my first time with github, if i made mistake, i'm sorry ;)

Hey, sweet! Thanks.

Looks good so far.

I'll review this more closely as soon as I can (today or tomorrow). If everything's okay, I'll cut a new release for you.

No pressure at all, but do you want to add your name to AUTHORS.md? This is just a way to give people recognition for their efforts.

t-mart commented 7 months ago

Ah, ok, you made two pull requests: this one and #72. Both are related to the same feature (your translation).

Could you add another commit to this pull request with the change from #72? Then, we can close it and just work on this one. That would be ideal because we only have to think about this feature in one place, instead of two.

PRs can involve any number of files. It's even common to repeatedly change the same file multiple times in the same PR as development continues.

You said you're new: Do you want to try to figure out how to do that on your own, or would you like some pointers?

Brainc3ll commented 7 months ago

Hello, thank you for your message, I think I've figured out how to do it ;)

My name is not needed in Authors.md thank you for proposing it

t-mart commented 7 months ago

Looks good to me.

https://github.com/t-mart/ItemVersion/assets/200012/52fa60dd-4052-4b01-9f66-8db120457c31

If you want to see what it will look like, get the file here named ItemVersion-4a04a1cbaceee87b4affba7b3255d77ca31e2a6c and put it in your AddOns directory.

I'm going to work on one more thing, and then I'll make a release.

t-mart commented 7 months ago

Release here: https://www.curseforge.com/wow/addons/itemversion/files/5165246

Thanks again!