On the 'Guitar' page, + is missing to select chords

t-mon / guitar-tools

Tool collection for guitar players and musicians.

GNU General Public License v3.0

5 stars 1 forks source link

On the 'Guitar' page, + is missing to select chords #4

Closed matv1 closed 5 years ago

matv1 commented 5 years ago

On the Xenial version, there is no way to select chords, as there is no plus sign in the menu, like there was in the original version.

matv1 commented 5 years ago

apparently, this has for some reason been actively been removed at one point. the lines have been commented out on the GuitarPlayerPage.qml lines 63-66 should be re-added

//            Action {
//                iconName: "add"
//                onTriggered: PopupUtils.open(chordSelectionComponent)
//            },

matv1 commented 5 years ago

actually, the fret-board icon is also missing. In fact it seems the whole pageheader section was copied from the guitar tuner page. Probably by mistake?

t-mon commented 5 years ago

Hi! Thanks for the bug report! I'll fix this today!

Looking at my own commits this happened probably when I started to migrate to the QtQuick controls 2!

t-mon commented 5 years ago

I just released the fix to the open store.