search

t-mullen / logoot-crdt

Optimized Logoot CRDT implementation.
37 stars 1 forks source link

warning running the test #1

Open m-onz opened 5 years ago

m-onz commented 5 years ago

hey,

Great library.. i was just running the tests on ubuntu 18 and I get streaming warnings until I stop the test. Do the tests work on other operating systems? I will continue to investigate

(node:2820) Warning: Possible perf_hooks memory leak detected. There are 68337 entries in the Performance Timeline. Use the clear methods to remove entries that are no longer needed or set performance.maxEntries equal to a higher value (currently the maxEntries is 150).
(node:2820) Warning: Possible perf_hooks memory leak detected. There are 68338 entries in the Performance Timeline. Use the clear methods to remove entries that are no longer needed or set performance.maxEntries equal to a higher value (currently the maxEntries is 150).
(node:2820) Warning: Possible perf_hooks memory leak detected. There are 68339 entries in the Performance Timeline. Use the clear methods to remove entries that are no longer needed or set performance.maxEntries equal to a higher value (currently the maxEntries is 150).
(node:2820) Warning: Possible perf_hooks memory leak detected. There are 68338 entries in the Performance Timeline. Use the clear methods to remove entries that are no longer needed or set performance.maxEntries equal to a higher value (currently the maxEntries is 150).
(node:2820) War^C
t-mullen commented 5 years ago

Seems like it's a bug in nanobus (the event library used): https://github.com/choojs/nanobus/issues/32

Looks like the fix is to disable the nanotiming API or upgrade Node. :/

Should swap out nanobus for the native EventEmitter when running in Node.

m-onz commented 5 years ago

Ok Thanks for the heads up. I will investigate those options and try and put in a PR.

m-onz commented 5 years ago

Also I plan to make an experiment using streams + webRTC... i think it should be straight foward to make a duplex stream for the message passing similar to https://github.com/dominictarr/scuttlebutt. I'll report back when I have some findings!

t-mullen commented 5 years ago

It's definitely possible to stream. The reason I didn't go with that approach is because readable-stream is such a large dependency and it's easy enough to wrap this module with a stream.

If you're going with Node.js-only, then you wouldn't really care about dependency size.