t-mullen / video-stream-merger

Merge multiple video MediaStreams into one composite.
https://t-mullen.github.io/video-stream-merger/
MIT License
357 stars 81 forks source link

Types not working (using complete types instead of partials) #96

Open Ivanca opened 1 year ago

Ivanca commented 1 year ago

Hello. Thank you for this repo.

The type checker is currently throwing some errors because the types at video-stream-merger\dist\index.d.ts do not match the types at src/index.ts, for example the constructor is accepting ConstructorOptions as an argument on the types file but Partial\<ConstructorOptions> in the source file.

index.d.ts: image

src/index.ts: image

This makes it mandatory to add options such as audioContext as an argument for the constructor which is not intended AFAIK, the current workaround is to set the options object "as any" but that's not optimal.

Thanks.