search

t-mw / gw2-arbitrage

Finds items in Guild Wars 2 that can be sold on the trading post for a higher price than the cost of crafting the item.
28 stars 5 forks source link

Default cache API calls for a few minutes #17

Closed Iiridayn closed 2 years ago

Iiridayn commented 2 years ago

As a matter of courtesy and so I'd be more comfortable re-running the script to refresh output, it'd be nice to cache api calls for a bit, and add a flag to refresh api data. Maybe it's only relevant when I'm testing, as I hit the API a bunch, and when not testing I don't mind having live data.

Iiridayn commented 2 years ago

Also, consider putting current cache files in .local/share (data_dir), since they are longer lived app data files.

Iiridayn commented 2 years ago

Ah, another key example - we get all the data to generate the big table; subsequent investigation shouldn't have to hit the API anew, since we just hit it.

Iiridayn commented 2 years ago

Closing - fixed by #23, except the big table, which market perturbations make caching effectively not worth the bother.