search

t-oster / LibLaserCut

a platform independant library to control Lasercutters. This is the base library for VisiCut
http://visicut.org
Other
60 stars 55 forks source link

GenericGcodeDriver: Add support for grblHAL HTTP-upload and static jo… #220

Closed pimsierhuis closed 7 months ago

pimsierhuis commented 7 months ago

…b name. Fixes #207

pimsierhuis commented 7 months ago

I modified my previous pull request to a simpler variant where you can only upload a file and have the option to provide a static name. Autostart is more difficult to implement with grlbhal and not needed for our use case (we want to have a physical button on the machine). So if needed, maybe that can be implemented later.

Please merge this one :)

pimsierhuis commented 7 months ago

@t-oster Do you have any chance to look at this? Sorry for being pushy by mentioning you, but I thought maybe you weren't noticed because the old PR was closed.

pimsierhuis commented 7 months ago

By the way, I tested this and it covers our use case.

mgmax commented 7 months ago

Looks good, I would merge in a week if there are no new comments/changes.

pimsierhuis commented 7 months ago

Cool, thanks. If that week could be a tiny little bit shorter (like merging on monday so we could start using it tuesday), that would be great.. :)