return error image when marker not detected

t-oster / VisiCam

A Java application, that turns a webcam into a VisiCut compatible network camera with marker detection and perspective correction. Uses OpenCV through JavaCV

Other

36 stars 12 forks source link

return error image when marker not detected #9

Closed mgmax closed 9 years ago

mgmax commented 9 years ago

If the marker cannot be found (e.g. when the camera has overexposure problems), no output image should be returned. I suggest returning a completely blue image or an error message (how?).

mgmax commented 9 years ago

why did you close the bugreport?

mgmax commented 9 years ago

we @fau-fablab tried fixing it and found two different ways of failure:

absolutely no marker found: could be fixed by checking for foundMarkers < 4
marker found, but a completely wrong position (corner of rectangle?): TODO

as soon as everything works we will send you a pullrequest

note to myself: loading of dummy image: https://github.com/t-oster/VisiCam/blob/master/src/com/t_oster/visicam/CameraController.java#L83

t-oster commented 9 years ago

hi, I don't remember closing the pull request. Maybe I miss-clicked. However, should be open again. Nice to know, that anybody is still using VisiCam.

mgmax commented 9 years ago

my first try is now online in fau-fablab/VisiCam , branch marker-improvements TODO: "error image" (all grey?) instead of HTTP error, or try to show the error response contents in VisiCut TODO: also raise error if marker is too near to the rectangle boundary (how near? enlarge rectangle for search?)

mgmax commented 9 years ago

now shows an error image. detected marker positions can be viewed in the web-interface: 5758228c7bf598e367f4d60c1055088805ecc85a