search

t-oster / VisiCut

A userfriendly tool to prepare, save and send Jobs to Lasercutters
https://visicut.org
Other
226 stars 114 forks source link

.gcode extension missing when exporting a file #609

Open danke-0x21 opened 3 years ago

danke-0x21 commented 3 years ago

Hi,

When using the "Export to G-CODE" menu (my UI is not in english), you have to manually add the .gcode extension to the file name. For instance, saving a file as PLF automatically add the .plf extension to the file name. Not a big deal, but you know... workflows are sensitive cases... :)

mgmax commented 3 years ago

I understand what you want, but the problem is that there are many different file endings for G-Code (.gcode, .ngc, .nc, .txt), and this also depends on the machine format (GCode / HPGL / whatever). So there is no easy fix. This would need to be a property of the specific lasercutter class or even a configuration option.

t-oster commented 3 years ago

I would not make it that complex. The file chooser should have a drop-down for the type where we specify .gcode (default), .txt and any. If the user enters the filename with suffix, we don't change it. If the suffix is missing we append what ever is selected in the drop-down.

danke-0x21 commented 3 years ago

I didn't know about all the suffixes used for the G-Code files.

Both solutions (option in lasercutter profile and drop down menu) have pro and cons. On the first one you can set the option for each lasercutter and then you don't bother anymore but you can't change it on the fly if needed. On the second one you don't bother at all if you use default .gcode, but people who needs another suffix won't see the benefits.

So both are good for me since I'm a .gcode suffix user. I can't tell for other people. On the other hand I have no programming skill so I can't help on which is the easiest to add.