search

t-wissmann / barpyrus

A python wrapper for lemonbar
Other
33 stars 7 forks source link

Gruvbox theme #10

Closed AckslD closed 3 years ago

AckslD commented 4 years ago

Hi @t-wissmann!

I've been customising my barpyrus panel and thought I would share it here. I'm not sure what's the best way to share customisations and if you don't want it in the repo. Anyway, the bar contains indicators for:

I've also changed the colorscheme with inspiration from the gruvbox theme. Not that I also made some changes in barpyrus/hlwm.py to do this. It looks as follows, with the matching theme in my terminal and vim:

Screenshot from 2020-04-26 15-54-18

Let me know what you think and if you would want this in the repo or not :)

t-wissmann commented 4 years ago

Thanks for sharing your config! I've added a few comments above.

I also think your config should be moved to share/examples. I'd like to keep the examples in share/ serve as entry points for new users and as general as possible (without paths/resource names hard-coded, etc). But it's very valuable to have a collection of more advanced configuration :)

AckslD commented 4 years ago

@t-wissmann, thanks for your comments, I'll update the PR later today

AckslD commented 4 years ago

@t-wissmann I fixed the things you pointed out. Btw something that should maybe still be done and it depends a bit on how you want to handle it. At the moment I have edited barpyrus/hlwm.py to edit colors of some things. However it is still not configurable from config.py. What's your view on this?

t-wissmann commented 3 years ago

Sorry for not writing earlier... I completely forgot about the open PRs in for barpyrus.. The color-settings look good, and I think one can configure the colors by adjusting the global variables. I think this is fine for the moment!

I'm adding some more comments. If it's fine for you I can also fix them, given that I was letting you wait for so long.

AckslD commented 3 years ago

Hi @t-wissmann! No problem :)

t-wissmann commented 3 years ago

@AckslD I took the freedom and edited the changes discussed above directly to this PR. (I hope you were not already working on it....) If it's fine for you, I can merge this PR as is

AckslD commented 3 years ago

Cool @t-wissmann, go ahead and merge :)

AckslD commented 3 years ago

Btw, just leaving a reference here for an updated version of the config that I've added things for from time to time and can be found here. It also has support for showing the current song playing (using playerctl and e.g. ncspot), clicking the wifi icon to see the current wifi name, toggling a onscreen-keyboard etc :)

t-wissmann commented 3 years ago

OK, thanks! :)