t0mer / ims-custom-component

The Israel Meteorological Service (IMS) integration component for home assistant
MIT License
35 stars 8 forks source link

[FR] More feature requests #90

Open elad-bar opened 1 week ago

elad-bar commented 1 week ago

Hi again,

I know that it's not the best practice to post list of issues/FR under one item, but before creating multiple thought to have it as single, and whatever will be decided, we will close / split that item, anything below is not just a suggestion for improvement / new feature, but also suggestion that i will implement and do PR for it, just don't want to work for nothing... hope it is ok

  1. Improvement - Current UV Level (ims_current_uv_level) – use the API lookups and names, use the language parameter of the API to generate translation (not in runtime).

More details: seems like calculated within the integration, no need to calculate it and declare values, it can be extracted from the API.

Solution: Endpoint below (7=Natanya, although they call it Natania) provides ability to extract also levels out of it within property - colorbar it has thresholds for UV levels, heat stress, wave height.

  1. Improvement - Remove sensor.ims_is_raining or at least change it to binary as its name implies for true/false

  2. Improvement - Change unit of measurement for sensor.ims_forecast_time to timestamp, will allow presenting it as X minutes ago, bit more clearer

  3. New feature - Warnings can be translated to events on map can be extracted from warnings property, mapped to areas (region)

  4. New feature - Configuration for location can be based on coordinates of HA, if not found, choose from a list of cities from locations property

  5. New feature - Wind direction can be added as sensor joined with wind_directions property

  6. New feature - All entities linked to city device - name of the city as device name

  7. New feature – On top of the above, allow to choose automatically generate devices by zones, in that case, name of the device will be the zone, for cases when zone is not available within the range of coordinates, allow the user to set manually using a service (add city – getting back to item above) - suggested as part of #26 .

Endpoints: • City portal - https://ims.gov.il/en/city_portal/{CITYID} • Locations - ims.gov.il/en/locations_info

GuyKh commented 1 week ago

Interesting ideas. I'll look into it

elad-bar commented 1 week ago

Thanks, Feel free to ping me if you would like me to promote one or more items, I created a small poc for coordinate distance related to item 8, pretty simple (i can share it if you would like)

GuyKh commented 1 week ago

@elad-bar thanks. I'd love that (contact me by mail from my profile). That would definitely save some time :D

I'm loaded with work so struggle to find time to work on that, plus there's IEC component