search

t0xa / gelfj

Graylog Extended Log Format (GELF) implementation in Java and log4j appender without any dependencies.
https://github.com/t0xa/gelfj/wiki
Other
186 stars 116 forks source link

Enhancement 1 #114

Open skorhone opened 8 years ago

skorhone commented 8 years ago

Multiple fixes / enhancements

t0xa commented 8 years ago

Hi @skorhone,

Wow, excellent work! It will take some time for me to review and merge changes. How urgently you need new version?

Anton

skorhone commented 8 years ago

Hi Anton,

it would be great, if changes could be merged. There's no hurry, as we're currently building our production versions from our fork

You might be more interested in master branch (trunk) It contains quite a few additions.

The most notable feature is support for sending messages asynchronously using dedicated dispatcher thread. I decided to add this feature, because losing messages occasionally is usually preferred over having application/application server halt.

Second useful addition is GelfHTTPSender. This is obviously restful client for graylog

Third somewhat notable change is the way JSON is built. I added a simple (well tested) JSON string encoder to remove dependency from 3rd party json library. JSON library may and propably will cause conflict on EE7 application servers. This change adds some limitations to custom fields (fields may only be primitives or strings), but I personally think that this limitation is reasonable.

And finally, I've tried to improve unit test coverage on parts where it matters the most. It's still far from perfect :-)

If you have any comments regarding coding style / unit test coverage, please let me know.

Best regards, Sami Korhonen

On Tue, Sep 6, 2016 at 11:20 PM, Anton Yakimov notifications@github.com wrote:

Hi @skorhone https://github.com/skorhone,

Wow, excellent work! It will take some time for me to review and merge changes. How urgently you new version?

Anton

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/t0xa/gelfj/pull/114#issuecomment-245077501, or mute the thread https://github.com/notifications/unsubscribe-auth/AEl6yOT6bCGrb_DbnwOU1_zUyQh-n6Vkks5qncr1gaJpZM4J068O .