t0xa / gelfj

Graylog Extended Log Format (GELF) implementation in Java and log4j appender without any dependencies.
https://github.com/t0xa/gelfj/wiki
Other
186 stars 116 forks source link

NullPointerExceptions #39

Closed kurtharriger closed 11 years ago

kurtharriger commented 11 years ago

I'm getting null pointer exceptions that appear to be originating from the graylog appender. Looking a bit into the code it appears the exception could be thrown if bytesList array contains null entries possibly? I have some log messages that dump an entire http response for debugging and I think perhaps the chunking logic doesn't properly handle large messages maybe?

java.lang.NullPointerException at sun.nio.ch.IOUtil.write(IOUtil.java:147) at sun.nio.ch.DatagramChannelImpl.write0(DatagramChannelImpl.java:439) at sun.nio.ch.DatagramChannelImpl.write(DatagramChannelImpl.java:456) at java.nio.channels.DatagramChannel.write(DatagramChannel.java:435) at org.graylog2.GelfSender.sendDatagrams(GelfSender.java:41) at org.graylog2.GelfSender.sendMessage(GelfSender.java:36) at org.graylog2.log.GelfAppender.append(GelfAppender.java:139) at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251) at org.apache.log4j.helpers.AppenderAttachableImpl.appendLoopOnAppenders(AppenderAttachableImpl.java:66) at org.apache.log4j.Category.callAppenders(Category.java:206) at org.apache.log4j.Category.forcedLog(Category.java:391) at org.apache.log4j.Category.log(Category.java:856) at org.slf4j.impl.Log4jLoggerAdapter.debug(Log4jLoggerAdapter.java:281)

kurtharriger commented 11 years ago

Probably should have mentioned I am using the master branch 1e3569bcb988a71bf853a0d3012c360214c6bb76 initially I was on gelf-1.0 when noticed the issue but saw some rework done so I built and deployed latest to see if that would resolve issue, but still seem to occur.

bjkastel commented 11 years ago

I've had the same problem and have opened pull request #48 with a fix for that issue.

t0xa commented 11 years ago

Thanks bjkastel!

superflav commented 11 years ago

What's the ETA on getting this available as in an updated download version?