Import Transaction as bug

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Import a CSV file.
2. Select 'Online' as the 'Import Transaction as' option.
3. Process the file.
4. Import a CSV file.
5. Select 'Regular' as the 'Import Transaction as' option.
6. Process the file.

What is the expected output? 

The expected behavior would be for either option to enter -Deposit- items
into the Deposit column and -Payment- items into the Payment column.

What do you see instead?

What happens instead is that the -Payment- and -Deposit- items are reversed if 
the user toggles between the 'Online' option and the 'Regular' 
option

What version of the product are you using? On what operating system?

Starting Moneydance 2012.5 (866) at Fri Jul 12 10:42:33 EDT 2013
Settings Folder: C:\Users\Kevin_2\.moneydance
OS: Windows 7 6.1 x86
Java: 1.7.0_07 (Oracle Corporation)
Is in sandbox: false; restricted file access: false
name and version =CSV Importer  Beta 15.7.11=
opening last file: Practice

HTH -Kevin N.

Original issue reported on code.google.com by kmnugent...@gmail.com on 12 Jul 2013 at 2:52

[GoogleCodeExporter]

mdcsvimporter-beta-15.7.13.zip - Online and Regular Transactions types both 
import with same sign

Original comment by stashu....@gmail.com on 26 Jul 2013 at 2:50

• Changed state: Fixed

[GoogleCodeExporter]

Hi Stan, 

Thank you for your work on this issue.

Selecting 'Online' or 'Regular' no longer reverses the -Payment- and -Deposit- 
fields.

However, importing the attached Issue-26.txt file into a Bank account, results 
in the
-Payment- and -Deposit- fields importing into their respective opposite columns 
in the register regardless of which option (Regular vs. Online) is chosen.

(See screenshot: Issue_26_Processed.jpg)
The Salary:Paycheck txn should land in the 'Deposit' column.
The ATM Withdrawal:Cash and Automotive:Fuel txns should land in the 'Payment' 
column.

HTH -Kevin N.

Original comment by kmnugent...@gmail.com on 26 Jul 2013 at 1:10

Attachments:

• Issue_26_Processed.jpg
• Issue_26_Reader.jpg
• Issue-26.txt

[GoogleCodeExporter]

Hi

Is this because of the account type?
I notice bank and checking I think import into opoosite columns like you
mention.
Payment and deposit for 1 acct type
Goes into charge and payment for the opposite acct type I saw last night.

I dont know how to read the acct type in the MD api so I left it and I
figure people can swap -payment- and -deposit- in my reader definition and
they would be fine.

If you can tell me how to read an acct type I could think about changing it.

If that's not your issue let me know.

Original comment by stashu....@gmail.com on 26 Jul 2013 at 1:26

[GoogleCodeExporter]

Hi Stan,

I'm afraid that the internal workings of Moneydance are far beyond the scope of 
my knowledge.

Swapping the -Payment- and -Deposit- fields so as to accommodate for different 
account types is easy enough.

Perhaps there should be some remark made at the bottom of the custom file reader
to the effect that the -Payment- and -Deposit- fields are not constant and may 
need
to be reversed dependent on the account type.

This will give the user a heads up to look out for a 'reversed' import.

-Kevin N.

Original comment by kmnugent...@gmail.com on 26 Jul 2013 at 1:48

[GoogleCodeExporter]

Ok.

Original comment by stashu....@gmail.com on 26 Jul 2013 at 1:50

[GoogleCodeExporter]

Hi Stan,

Playing around with this some more...

As you mentioned the Payment and Deposit columns of a Bank type account seem to 
coincide with the Charge and Payment columns of a Credit Card account.

That said, I imported the Issue-26.txt file into a Credit Card account and the 
results were similar to the Bank account import.  
The data seems to land into the wrong columns.

I can't help but think that this is a direct result of the 'Regular' vs. 
'Online' 
reversals that were happening before.
Choosing one option provided the correct import.
Choosing the other option, the import was reversed.

Perhaps a simple solution could be to rename -Payment- to -Deposit- and 
vice-versa
in the custom file reader drop-down list.

-Kevin N.

Original comment by kmnugent...@gmail.com on 26 Jul 2013 at 3:08

Attachments:

• Issue_26_CC_Processed.jpg

[GoogleCodeExporter]

I'm pretty sure it works correctly for half the account types.

Do bank and credit card use the same columns? If so that is not a valid
check. And in that case you would be correct to rename them.

Is there a checking account type maybe? See if that shows Payment and
Deposit columns and I'll bet those show up correctly.

Let me know.

Stan
 On Jul 26, 2013 11:08 AM, <mdcsvimporter@googlecode.com> wrote:

Original comment by stashu....@gmail.com on 26 Jul 2013 at 3:15

[GoogleCodeExporter]

Hi Stan,

I used Issue-26.txt for each import.

The screenshot in post # 2 (Issue_26_Processed) is of a Checking account.
The screenshot is post # 6 (Issue_26_CC_Processed) is of a Credit Card account.

As you can see, the columns are labeled differently but the data lands in the 
same
columns.

In each case, the data lands in the wrong columns.

I can simply reverse the -Payment- and -Deposit- options in the custom file 
reader
to fix the problem but I'm wondering if the labeling of those two items should 
be 
changed so as to more accurately reflect the CSV file's actual column structure.

As it stands now, they appear to be reversed.

-Kevin N.

Original comment by kmnugent...@gmail.com on 26 Jul 2013 at 6:30

Attachments:

• Issue-26.txt

[GoogleCodeExporter]

Hi Kevin,
Look at your screen shots next to each other again. As you and I say, the data 
lands in the same columns both times.
But when you says "In each case, the data lands in the wrong columns.", look 
again:
The $25 payments in your import file are in the payment column for your credit 
card so that is correct.
They are in the wrong/opposite/deposit column for the checking account.

Also think about it. You said 1.) the data imports into the same columns,
2.) and the columns are labeled differently (opposite) between credit card & 
checking
So they have to be correct one way and wrong the other :-)

That is what I said would happen. I think MD is reversing the sign depending on 
the account type and I did not see an easy way know which ones MD reverse or 
not. They have about 10 account types. I now know these 2 types are opposite 
but how much do I want to play with it?

Original comment by stashu....@gmail.com on 27 Jul 2013 at 9:29

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Hi. I could get into:
Do I want to try to match MD "names" of their columns for their different 
account types. Then I would add 'Charge', 'Increase', 'Decrease'. Here I would 
have to play around and figure out payment is positive if they also use a 
'charge' field, and then reverse payment sign if they use a deposit field.

MD maybe is not consistent in that for Asset and Liability they do not swap the 
columns like they do for Bank and Credit Cards.

I could even make it simpler and just do 'Positive Amount' and 'Negative Amount'
or 'Amount' and 'Reverse Amount' or something.

Original comment by stashu....@gmail.com on 27 Jul 2013 at 10:04

[GoogleCodeExporter]

Hi Stan,

I think the term 'Payment' is what's at play here.  It has a different and 
opposite meaning when it comes to Bank accounts vs. Credit Card accounts.

A 'Payment' comes out of a Bank account and is akin to a Debit.
A 'Payment' goes into a Credit Card account and is akin to a Credit.

So yes, I can see how it creates a conundrum when importing to both Bank and 
Credit Card accounts

With regard to adding additional terminologies or using 'Positive Amount' and 
'Negative Amount', perhaps 'Debit' and 'Credit' might fit the bill.

To be honest, for me, -Payment- and -Deposit- are fine.

I think that in the interest of keeping it simpler, having a remark at the 
bottom of the file reader indicating that 'The -Payment- and -Deposit- fields 
are not constant across different account types and may need to be reversed' 
would suffice for most users.

Thanks for resolving the original 'Online' vs. 'Regular' issue.

BTW, if it's not too difficult to explain, what is the difference between 
selecting 'Online' vs. 'Regular'?  I had a user ask on the MD forums and I 
wasn't quite sure what to tell them.

Thanks again,
-Kevin N.

Original comment by kmnugent...@gmail.com on 28 Jul 2013 at 12:44

[GoogleCodeExporter]

btw, I changed my 'Suggestion' label tool-tip to a button, and added a note in 
there about payment and deposit just being opposites of each other and can be 
flipped if needed. This is in 15.7.14 build which I asked Moneydance to make 
their default. I will probably publish it here after they do.

Original comment by stashu....@gmail.com on 6 Aug 2013 at 2:56

[GoogleCodeExporter]

Hi Stan,

Thank you.  I will keep an eye out for it.  

Regards,
-Kevin N.

Original comment by kmnugent...@gmail.com on 6 Aug 2013 at 1:36