t184256 / xontrib-prompt-vi-mode

vi-mode status formatter for xonsh prompt
MIT License
11 stars 4 forks source link

White bar under current prompt line #3

Open mogenson opened 5 years ago

mogenson commented 5 years ago

After loading the xontrib from the master branch of this repo I see a white bar underneath my current prompt line. There is also about a one second delay after I press any key, before it is displayed in the terminal.

prompt-vi-mode

Otherwise, this xontrib seems to be working correctly. Setting $RIGHT_PROMPT = '{vi_mode}' shows the current input mode.

Is this white bar the intended behavior? Why does it seem to slow down the shell so much.

t184256 commented 5 years ago

Unfortunately, I've just left for a trip leaving most of my devices behind and I cannot address the issues you've reported until the next week.

I don't know what causes the appearance of the white bar, and it's definitely not the intended behavior, but the sluggishness is expected.

The implementation relies on reevaluating all the prompts on each keypress, which is as horrible as it sounds, and gets even worse when VCS queries get involved.

mogenson commented 5 years ago

No worries, just thought I'd check.

t184256 commented 5 years ago

I can replicate this.

For some reason, $UPDATE_PROMPT_ON_KEYPRESS = True causes the white line to appear.

Granitosaurus commented 5 years ago

What $SHELL_TYPE are you guys running?

I can't replicate this with:

$SHEEL_TYPE='ptk2'
# maybe bottom bar is affecting it?
$PTK_STYLE_OVERRIDES['bottom-toolbar'] = 'noreverse'