t1mwillis / GWCode-EE3-EE4-EE5

A fork of the GWCode module to support EE3+ as well as PHP7
14 stars 6 forks source link

EE4 Compatibility Update #2

Closed ignetic closed 4 years ago

ignetic commented 5 years ago

Updated SQL where EE4 uses separate tables for custom fields

t1mwillis commented 5 years ago

@ignetic thanks for the PR. Would this likely solve the outstanding issue?

ignetic commented 4 years ago

@t1mwillis Only just getting back to you on you question after doing another update on this. I have this running on a live production site for some time now where I haven't yet seen any of the outstanding issues with it. The deprecated "create_function" is obviously one that stands out, I may have a look at that and see how that can be replicated.

ignetic commented 4 years ago

@t1mwillis I've now managed to fix the issue with the deprecated notice as in https://github.com/t1mwillis/GWCode-EE3-EE4-EE5/issues/3. Tested up to php7.3.