t1mzzz / pe

0 stars 0 forks source link

Phone number minimal condition is not suitable #8

Open t1mzzz opened 2 years ago

t1mzzz commented 2 years ago

The phone number field for candidates requires a minimum of 3 digits, which is not ideal. Ideally, it should be greater than 3 digits (e.g. Singapore's is 8 digits).

nus-se-bot commented 2 years ago

Team's Response

According to https://en.wikipedia.org/wiki/N11_code, there are abbreviated 3 digit valid telephone numbers eg. 911. While this is unlikely to be used for normal recruiting needs, we made our application as accommodating as possible for all use cases.

Moreover, certain islands and territories like Saint Helena and Niue have 4 digit valid phone numbers.

Hence, we feel that 3 was the correct minimum number of digits for a phone number.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that the 3-digit valid telephone numbers (911, 811, etc) will never be used by recruiting and hiring managers for candidate tracking. The minimal condition to be just 3 digits is definitely not ideal.

As this application can be used by international people (possibly looking to hire remote workers), the constraints on phone numbers have to be really specific (possibly need to add country code). Yes, Saint Helena and Niue may have 4 digit valid phone numbers, but this brings up another problem.

Saint Helena and Niue have 4-digit valid phone numbers. If somehow 2 phone numbers are the same (e.g a Saint Helena phone number is 8818 and a Niue phone number is 8818), how do we differentiate these? There will be no way of differentiating these 2 phone numbers. Possibly a solution to this is to allow country codes in phone number inputs, or storing the country of residence of the person.

As a result, the minimal condition is definitely not suitable for the purpose of this application. In this case, it is definitely not ideal for the minimal condition to be just 3 digits. I believe a Low or Medium severity is suitable for this bug.