t2bot / matrix-media-repo

Highly configurable multi-domain media repository for Matrix.
https://docs.t2bot.io/matrix-media-repo
MIT License
206 stars 79 forks source link

Ensure the remoteAddr being logged is the client IP used by the rate limiter #598

Open tux93 opened 2 months ago

tux93 commented 2 months ago

Quoting from Matrix:

TravisR|09:00 PM the remote address appears to be added to the log context before the rate limiter, so it's possible that it's just not logging the value at all David|09:02 PM So what gets logged as remoteAddr is not what the rate limiter uses? TravisR|09:02 PM correct it would be a bug, if you'd like to open an issue