Closed ghost closed 1 year ago
I was under the impression of getting a PR similar to https://github.com/t2linux/wiki/pull/446
Do you wish to add more changes?
I was under the impression of getting a PR similar to #446
Do you wish to add more changes?
I think they are doing it in multiple PRs
Approving it for the sake of running lint
Approving for lint again
Dash typos in docs should be over. Fixed also the remaining lint issues.
Lint issues should be over now.
Most changes seem to make things complicated, anyways I’ve requested some changes for now, will have to do another review after they are made.
This seems also to me when comparing the git diff. Git diff may be good for coding, but for text it may make you lose the "catch" behind the commit. I personally worked comparing the two preinstall.md in an editor where formatting is expressed. Github diff lines don't give me enough context.
You'll have to revert https://github.com/t2linux/wiki/pull/447/commits/e6e0838e5e772577acfea012b6bb449eec8301fd as well to fix the wrong revert you did.
The PR probably can be merged after the wrong revert is fixed.
Thanks for you contribution :)
Reworking mainly preinstall.md and adjusting other typos/formatting issues in docs.