search

t2linux / wiki

Repository for the t2linux.org wiki
https://wiki.t2linux.org
Creative Commons Attribution Share Alike 4.0 International
174 stars 61 forks source link

Pre Install guide rework #447

Closed ghost closed 1 year ago

ghost commented 1 year ago

Reworking mainly preinstall.md and adjusting other typos/formatting issues in docs.

AdityaGarg8 commented 1 year ago

I was under the impression of getting a PR similar to https://github.com/t2linux/wiki/pull/446

Do you wish to add more changes?

sharpenedblade commented 1 year ago

I was under the impression of getting a PR similar to #446

Do you wish to add more changes?

I think they are doing it in multiple PRs

AdityaGarg8 commented 1 year ago

Approving it for the sake of running lint

AdityaGarg8 commented 1 year ago

Approving for lint again

ghost commented 1 year ago

Dash typos in docs should be over. Fixed also the remaining lint issues.

ghost commented 1 year ago

Lint issues should be over now.

ghost commented 1 year ago

Most changes seem to make things complicated, anyways I’ve requested some changes for now, will have to do another review after they are made.

This seems also to me when comparing the git diff. Git diff may be good for coding, but for text it may make you lose the "catch" behind the commit. I personally worked comparing the two preinstall.md in an editor where formatting is expressed. Github diff lines don't give me enough context.

AdityaGarg8 commented 1 year ago

You'll have to revert https://github.com/t2linux/wiki/pull/447/commits/e6e0838e5e772577acfea012b6bb449eec8301fd as well to fix the wrong revert you did.

AdityaGarg8 commented 1 year ago

The PR probably can be merged after the wrong revert is fixed.

ghost commented 1 year ago

You'll have to revert e6e0838 as well to fix the wrong revert you did.

Did you mean this: a939310

AdityaGarg8 commented 1 year ago

Thanks for you contribution :)