t2pellet / strawgolem

Adds a cute straw golem to farm for you!
https://www.curseforge.com/minecraft/mc-mods/straw-golem-reborn
GNU Affero General Public License v3.0
16 stars 17 forks source link

Straw Golems Not Harvesting/Delivering #147

Open NetherResonant opened 1 month ago

NetherResonant commented 1 month ago

Currently running a 1.19.2 server on Fabric and golems are incredibly inconsistent about harvesting or especially delivering crops. I'm lucky to even get them to harvest a crop, maybe they'll work for the first one or two crops, but after that, they'll harvest and hold a crop and then just sit in some random corner and never drop off their crop. Not even assigning them to a container fixes things, punching them to get them to drop the item and reset doesn't work, the only thing that occasionally does is pushing them around and hoping they end up on a block right next to the delivery container, and only then do they sometimes actually put something in, only to go repeat the process with another crop immediately after.

This is with straw golem version 1.19.2-2.2.0 for Fabric. And Haybale 1.19.2-0.4.2-beta for Fabric.

There are no errors in the server console or anything that would lead me to something preventing them from functioning properly. Nor am I finding anything in the configs that would suggest any hints to a fix. Setting their lifespan to be unlimited or not doesn't change anything, or their container search range. It doesn't appear to be anything with a hunger mechanic either, because these are freshly spawned golems performing this behavior, and there's no mention of any hunger mechanics with apples or anything in the config file.

NetherResonant commented 1 month ago

Update: After doing some testing with the golems, it appears that if the field they're wandering has only one type of crop, they work flawlessly. No hitches, they just walk slow. But they consistently harvest and deposit crops. But the second you start introducing a second crop into the field, it seems to break their AI. He'll pick up a potato and then just stand there and not do anything, but the second all the wheat seeds are broken and removed, he resumes business and deposits his potato before going to harvest another.

...Or maybe it's just if too many crops grow at once they get confused? That seems to be the more plausible answer after a bit more testing. It's easier to see when the random tick speed is set ludicrously high and an entire field grows instantaneously, they immediately get confused and freeze up unless they happen to be standing right beside the barrel, in which case they'll constantly pick up crops and put them in the barrel immediately. It's definitely noticeable, but it's not the sole thing I've noticed for when they stop working. Sometimes it just seems completely arbitrary.

Another bug I've also noticed with them is sometimes they will play their "Interested" sound constantly, spamming it fast enough to completely fill up all available sounds and then permanently disable sounds until you close out of the world. It seems to happen when another golem or player harvests a crop they were previously targeting. And when a golem interrupts their "Interested" sound, it gets permanently stuck in your current sounds list, regardless of the fact that nothing is actually playing, which in turn is why once all 247 available sound spots are filled with these junk noises, the entire game goes silent because nothing else can play.