t2t2 / obs-tablet-remote

Tablet optimised OBS Remote
http://t2t2.github.io/obs-tablet-remote/
MIT License
424 stars 129 forks source link

Feature request: custom websocket URL #29

Open andreymal opened 6 years ago

andreymal commented 6 years ago

I use nginx as reverse-proxy for OBS with configuration like this:

server {
  listen 443 ssl default_server;
  listen [::]:443 ssl default_server;
  server_name home.andreymal.org;

  ssl_certificate /etc/letsencrypt/live/home.andreymal.org/fullchain.pem;
  ssl_certificate_key /etc/letsencrypt/live/home.andreymal.org/privkey.pem;

  location /obs/ws/ {
    proxy_pass http://127.0.0.1:4444;
    proxy_http_version 1.1;
    proxy_read_timeout 3600;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "upgrade";
  }
}

It uses Let's Encrypt HTTPS certificates. I can connect to OBS websocket:

var _socket = new WebSocket('wss://home.andreymal.org/obs/ws/');

It works great.

But obs-tablet-remote does not allow this!

Please add an option to use custom websocket URL for me. And also please allow HTTPS :)

P.S. https://github.com/Palakis/obs-websocket/issues/26 lies! :D

timokorkalainen commented 4 years ago

Now that #63 and #64 are merged this could be considered done.

The only caveat now should be if you need to define a port and have other than root url path such as wss://example.com:4444/obs. In that case you must know to actually type the port as part of the url in the url field and leave the port field empty. A better parsing of the url & port should be done to cover that case, but I do suspect that is rather rare an occasion.