t2v / play2-auth

Play2.x Authentication and Authorization module
Apache License 2.0
608 stars 142 forks source link

support controller tests without application in context #160

Closed liorhar closed 8 years ago

liorhar commented 9 years ago

WithApplication tests are much slower (starting a new app for every controller test) this pull request remove the assumption there's a play application in context allowing faster tests

gakuzzzz commented 8 years ago

Wow!! I'm sorry for losing this PR.

And thanks, it is usefull.

liorhar commented 8 years ago

thanks. Actually with the recent release of Play 2.5 and the deprecation of Play.current this solution is useless. Migrating to 2.5 will mean any static access to Play and Crypto will have to be rewritten.

gakuzzzz commented 8 years ago

Thanks, you are right.

I'll publish a new release for Play2.4. And now, I'm migrating to 2.5.