search

t2v / play2-auth

Play2.x Authentication and Authorization module
Apache License 2.0
608 stars 142 forks source link

Need debug logging when authorization failed #173

Open tototoshi opened 8 years ago

tototoshi commented 8 years ago

When authorization failed from exception thrown by underlying modules like db or cache api, the detail is ignored and not recorded. Due to this, debugging is very hard.

https://github.com/t2v/play2-auth/blob/release0.14.2/module/src/main/scala/jp/t2v/lab/play2/auth/AsyncAuth.scala#L9-L22

Will you add debug logging where recover and recoverWith?

} recoverWith {
      case e =>
           logger.debug(e.getMessage, e)
           authenticationFailed(request).map(Left.apply)
}
gakuzzzz commented 8 years ago

Good proposal!

I consider the way of getting logger instance...

tototoshi commented 8 years ago

why not play.api.Logger?