[runtime preprocess][rare use case] Syntax errors with apostrophe ' in id

[t2ym]

[runtime preprocess][rare use case] Syntax errors with apostrophe ' in id

Root Cause

• At runtime preprocessing with i18n.js, apostrophe characters are not escaped in generated JavaScript expressions

Reproducible Code

  html`${bind(this)}<span id="id-with-apostrophie'">hello</span>`

Workaround

• Avoid apostrophe ' characters in id

Notes

• This issue is not reproducible with preprocessed sources at build time

Fix

diff --git a/i18n.js b/i18n.js
index 2c17905..3a00222 100644
--- a/i18n.js
+++ b/i18n.js
@@ -527,7 +527,7 @@ export const html = (strings, ...parts) => {
             }
             while (partPath.length) {
               tmpPart = partPath.shift();
-              valueExpression += `['${tmpPart}']`;
+              valueExpression += `["${tmpPart}"]`;
             }
             if (isJSON) {
               valueExpression = `JSON.stringify(${valueExpression}, null, 2)`;