[buildtime preprocess][rare use case] SyntaxError: Unexpected token "][" with quotation " in id

[t2ym]

[buildtime preprocess][rare use case] SyntaxError: Unexpected token "][" with quotation " in id

Root Cause

• " is not escaped properly in generating preprocessed codes

Reproducible Code

  html`${bind(this)}<span id="id-with-&quot;">hello</span>`

Fix

diff --git a/demo/gulpfile.js b/demo/gulpfile.js
index 9ce403c..eb41561 100644
--- a/demo/gulpfile.js
+++ b/demo/gulpfile.js
@@ -350,7 +350,7 @@ function traverseAst(ast, templates) {
                       valueExpression = 'effectiveLang';
                     }
                     while (tmpPart = partPath.shift()) {
-                      valueExpression += `["${tmpPart}"]`;
+                      valueExpression += `["${tmpPart.replace(/"/g, '\\"')}"]`;
                     }
                     if (isJSON) {
                       if (useI18nFormatDataProperty) {

Workarounds

• Avoid using " in id attributes