[observeHtmlLang] super.render() can have incorrect lang when observeHtmlLang is false - Githubissues

t2ym / i18n-element

I18N Base Element for Lit and Polymer

Other

9 stars 1 forks source link

[observeHtmlLang] super.render() can have incorrect lang when observeHtmlLang is false #81

Closed t2ym closed 5 years ago

t2ym commented 5 years ago

[observeHtmlLang] super.render() can have incorrect lang when observeHtmlLang is false

Root Causes

Contexts for observeHtmlLang = false is not properly handled
lang-updated event for super is not captured for this
this._fetchStatus can have incorrect properties when multiple instances are created

Fix

Add static get observeHtmlLang() property to set this.observeHtmlLang at super() constructor
- This is a design change
Forward lang-updated events from the bound element for super to this element
Maintain this._fetchStatus object per instance when this.observeHtmlLang is false

Notes

This fix should not affect behaviors when observeHtmlLang = true, which is the default value
This fix may not be robust enough to handle all the cases with extended element classes
- I appreciate if you raise issues on observeHtmlLang = false cases