[super.render()] lang attribute flips to en with re-rendered elements - Githubissues

t2ym / i18n-element

I18N Base Element for Lit and Polymer

Other

9 stars 1 forks source link

[super.render()] lang attribute flips to en with re-rendered elements #85

Closed t2ym closed 5 years ago

t2ym commented 5 years ago

[super.render()] lang attribute flips to en with re-rendered elements

Root Cause

this element misses to catch lang-updated events from boundElement since the event listener is added AFTER a lang-updated event is dispatched

Fix

If boundElement.lang is different from this.lang at its boundElement association, this.lang has to be initialized by boundElement.lang as this element should have missed the lang-updated event.

Workarounds

Option # 1 - Specify lang attribute explicitly

html`${bind(this)}
${repeat(this.timezones,
(item) => item,
(item, index) => 
html`<world-clock .timezone=${item} lang=${this.lang} discard-on-disconnect>
<!-- explicitly set lang attribute to work around the flapping language issue on reconnect --></world-clock>`)}`

Option # 2 - static get observeHtmlLang() { return false; } and set lang attribute explicitly