[I18nElement base class] registered lifecycle callback is not called for extended Polymer classes but the 1st one - Githubissues

t2ym / i18n-element

I18N Base Element for Lit and Polymer

Other

9 stars 1 forks source link

[I18nElement base class] registered lifecycle callback is not called for extended Polymer classes but the 1st one #93

Closed t2ym closed 4 years ago

t2ym commented 4 years ago

[I18nElement base class] registered lifecycle callback is not called for extended Polymer classes but the 1st one

Root Cause

import { I18nElement } from "i18n-element/i18n-element.js", which is identical to BaseElements.I18nElement, is a constant PolymerGenerated class object whose PolymerGenerated.prototype.__hasRegisterFinished property is set as true when the first element instance is created, which prevents other extended element classes from calling their own registered lifecycle callbacks

Partial Fix

Make BaseElements.I18nElement a dynamic property
- Note: No source compatible fix for import { I18nElement } from "i18n-element/i18n-element.js"
```
diff --git a/i18n-element.js b/i18n-element.js
index 77382be..a82ea12 100644
--- a/i18n-element.js
+++ b/i18n-element.js
@@ -182,4 +182,10 @@ Mixins.Logger = Logger;
```
- @memberof BaseElements */ export const I18nElement = Mixins.Localizable(LegacyElementMixin(HTMLElement)); -BaseElements.I18nElement = I18nElement; +Object.defineProperty(BaseElements, 'I18nElement', {
get: function() {
return Mixins.Localizable(LegacyElementMixin(HTMLElement));
},
enumerable: true,
configurable: false, +});

Workaround

Use Mixins.Localizable(LegacyElementMixin(HTMLElement)) for each extended element class instead of I18nElement
- import { LegacyElementMixin } from '@polymer/polymer/lib/legacy/legacy-element-mixin.js';

Notes

This is the root cause of https://github.com/t2ym/i18n-behavior/issues/81